Implement llama-pull tool #16132
Open
Implement llama-pull tool #16132
+136
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Complete llama-pull tool with documentation Signed-off-by: Eric Curtin <[email protected]>
ngxson
reviewed
Sep 29, 2025
Comment on lines
+52
to
+56
| if (!params.model.hf_repo.empty() && !params.model.docker_repo.empty()) { | ||
| LOG_ERR("error: cannot specify both -hf and -dr options\n"); | ||
| print_usage(argc, argv); | ||
| return 1; | ||
| } |
There was a problem hiding this comment.
this should be checked inside common_params_parse, right?
Comment on lines
+58
to
+59
| // Initialize llama backend for download functionality | ||
| llama_backend_init(); |
There was a problem hiding this comment.
Why we need to initialize the inference backend to download the model?
Comment on lines
+21
to
+22
| LOG(" -o, --output PATH output path for downloaded model\n"); | ||
| LOG(" (default: cache directory)\n"); |
There was a problem hiding this comment.
Are you sure that the -o is currently handled this way?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete llama-pull tool with documentation